RFR: 8293976: Use unsigned integers in Assembler/CodeBuffer::emit_int*

Vladimir Kozlov kvn at openjdk.org
Mon Sep 19 23:49:54 UTC 2022


On Sun, 18 Sep 2022 19:43:22 GMT, Quan Anh Mai <duke at openjdk.org> wrote:

> Assembler/CodeBuffer::emit_int* accept signed int arguments.
> 
> - Since we are trying to emit some bit patterns into the code buffer instead of doing integer arithmetics, it makes more sense to use unsigned parameters.
> 
> - It makes usage with constants become inconvenient, as an integer literal is positive, a 0xC0 does not fit into an int8_t, resulting in the compiler complaining about lossy implicit conversions, the current solution is manual casting of the constants to unsigned char, which can be converted to int8_t without complaints.
> 
> Please have a look and leave some reviews. Thanks very much.

Testing passed.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10325


More information about the hotspot-compiler-dev mailing list