RFR: 8294014: Remove redundant UseCompiler conditions

Tobias Hartmann thartmann at openjdk.org
Tue Sep 20 11:42:43 UTC 2022


On Mon, 19 Sep 2022 13:46:09 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Several areas that use CompileBroker::should_compile_new_jobs() also contain a UseCompiler check which isn't needed, since the aforementioned already contains a check for this flag. In some areas (Such as with compileBroker.cpp which has AlwaysCompileLoopMethods) this duplicated check is required, so we can mark should_compile_new_jobs() and the related get_compilation_activity_mode() as inline to make the obvious optimization more obvious to the compiler used in the build (This should be fine, since both are small methods).

Looks good to me too.

I'll run some quick sanity testing before sponsoring.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10342


More information about the hotspot-compiler-dev mailing list