RFR: JDK-8293978: Duplicate simple loop back-edge will crash the vm [v4]

王超 duke at openjdk.org
Tue Sep 20 12:02:58 UTC 2022


On Tue, 20 Sep 2022 08:28:27 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> 王超 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change test
>
> test/hotspot/jtreg/compiler/c2/TestDuplicateSimpleLoopBackedge.java line 27:
> 
>> 25:   * @test
>> 26:   * @bug 8293978
>> 27:   * @library /test/lib
> 
> Not required anymore.

done

> test/hotspot/jtreg/compiler/c2/TestDuplicateSimpleLoopBackedge.java line 36:
> 
>> 34: public class TestDuplicateSimpleLoopBackedge {
>> 35:     static void zero(Byte[] a) {
>> 36:         for (int e = 0; e < a.length; e++)
> 
> I think it's better to always add braces, same below for the `while` and `if`.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10329


More information about the hotspot-compiler-dev mailing list