RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v6]

Tobias Holenstein tholenstein at openjdk.org
Wed Sep 21 08:07:13 UTC 2022


On Tue, 20 Sep 2022 13:20:38 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>>> I tried out the latest changes and it works as expected, thanks! However, I found one more case where the Control Flow window get out of sync with the active graph: if you open a graph and then go to the Outline and click on "Remove selected graphs and groups" (where only the opened graph is selected), the active graph changes to another graph in the same group but the Control Flow window still shows the CFG of the removed graph. Even though this problem is not introduced by this changeset, I suggest addressing it here.
>>> 
>>> Also, please make sure that the NetBeans-generated code moved by this changeset is still editable in its new context.
>> 
>> Thanks for trying it out! You are right. It also happens when deleting a graph with a smaller index number in the same group. The reason is that the `RangeSliderModel` saves the index of the current open graph. If the index number changes (what happens when you delete a graph with index <= current index), during repainting a different graph is painted. 
>> 
>> If you don't mind I prefer filing a Bug for this and solve it separately
>
>> If you don't mind I prefer filing a Bug for this and solve it separately
> 
> Sure, makes sense given that the bug seems to have a different root cause.

@robcasloz I checked that NetBeans-generated is still editable.

@chhagedorn I have applied the code style changes you suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/10196


More information about the hotspot-compiler-dev mailing list