RFR: JDK-8293364: IGV: Refactor Action in EditorTopComponent and fix minor bugs [v14]

[Tobias Holenstein]

On Wed, 21 Sep 2022 09:10:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove empty componentOpened()
>
> Thanks for doing the suggested updates. Apart from two small things, it looks good to me!

@chhagedorn and @robcasloz thanks for the reviews!

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/EnableBlockLayoutAction.java line 35:
> 
>> 33: public class EnableBlockLayoutAction extends EnableLayoutAction {
>> 34: 
>> 35:     private final EditorTopComponent editor;
> 
> The field can also be moved to `EnableLayoutAction` as it is used in all subclasses.

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/ExpandAdjacentAction.java line 41:
> 
>> 39:     }
>> 40: 
>> 41:     protected void expandFigures(AdjacentOperator adjacentOp) {
> 
> You could also directly use the predefined `Function` interface for one argument functions with return value:
> Suggestion:
> 
>     protected void expandFigures(Function<Figure, List<Figure>> adjacentOp) {

done

-------------

PR: https://git.openjdk.org/jdk/pull/10170