RFR: 8290401: Support dump all phases and print nodes in ascending order of index [v2]

Xin Liu xliu at openjdk.org
Wed Sep 21 18:08:40 UTC 2022


On Wed, 21 Sep 2022 17:55:18 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> * Sort nodes by index (`S` flag)
>> * increase max node distance to maximum number of nodes
>> * `DEBUG` phase for `-XX:CompileCommand=PrintIdealPhase` is currently unused. We propose to use `DEBUG` phase for printing all phases. Alternatively, we can add a new `ALL` phase. Seeking opinions from the community.
>> 
>> Thanks Xin Liu for working with me on this.
>
> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Create new phase `PHASE_ALL`

src/hotspot/share/opto/phasetype.hpp line 173:

> 171:         _valid = false;
> 172:       } else if (PHASE_ALL == cpt) {
> 173:         mask = ~((uint64_t)0);

Can we also change this from uint64_t to UINT64_C for the consistent style?

-------------

PR: https://git.openjdk.org/jdk/pull/10371


More information about the hotspot-compiler-dev mailing list