RFR: 8294190: Incorrect check messages in SharedRuntime::generate_uncommon_trap_blob [v2]

Aleksey Shipilev shade at openjdk.org
Thu Sep 22 08:40:51 UTC 2022


On Thu, 22 Sep 2022 08:27:33 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   generate_deopt_blob -> generate_uncommon_trap_blob
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2554:
> 
>> 2552:     __ cmpw(rscratch1, (unsigned)Deoptimization::Unpack_uncommon_trap);
>> 2553:     __ br(Assembler::EQ, L);
>> 2554:     __ stop("SharedRuntime::generate_deopt_blob: expected Unpack_uncommon_trap");
> 
> Suggestion:
> 
>     __ stop("SharedRuntime::generate_uncommon_trap_blob: expected Unpack_uncommon_trap");

Oh, indeed, see new commits.

-------------

PR: https://git.openjdk.org/jdk/pull/10388


More information about the hotspot-compiler-dev mailing list