RFR: 8294190: Incorrect check messages in SharedRuntime::generate_uncommon_trap_blob [v2]
Tobias Hartmann
thartmann at openjdk.org
Thu Sep 22 08:53:16 UTC 2022
On Thu, 22 Sep 2022 08:40:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> The checks added by [JDK-8141133](https://bugs.openjdk.org/browse/JDK-8141133) are not consistent. The blocks that verify `Deoptimization::Unpack_uncommon_trap` kind are saying "last_Java_fp not cleared" for some arches.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> generate_deopt_blob -> generate_uncommon_trap_blob
Good catch, @dean-long. Still looks good.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10388
More information about the hotspot-compiler-dev
mailing list