RFR: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob [v2]

Fei Yang fyang at openjdk.org
Thu Sep 22 09:34:15 UTC 2022


On Thu, 22 Sep 2022 07:04:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Looks fine to me, looks like typo, and this matches what x86 does. But, do you understand what code clears `last_java_fp`?

>From the code comments at [1], I think 'last_java_fp' is ensured to be zero here since we are not in the C land.
Hope that explains :-)

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L615

> While we are at it, we might put this on the same line:
> 
> ```
>     __ ldr(rscratch1, Address(rthread,
>                               JavaThread::last_Java_fp_offset()));
> ```

Fixed. Thanks for the review.

-------------

PR: https://git.openjdk.org/jdk/pull/10382


More information about the hotspot-compiler-dev mailing list