RFR: 8294245: Make Compile::print_inlining_stream stack allocated

Johan Sjölen jsjolen at openjdk.org
Fri Sep 23 17:19:20 UTC 2022


On Thu, 22 Sep 2022 17:10:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> Could I have  a review for this? It simplifies some auxiliary code in the Compile class related to its usage of stringStream. The only notable disadvantage is that Compile will take up `sizeof(stringStream) - sizeof(stringStream*)` more space on the stack.
> 
> Currently testing tier1-3 for this change, no errors yet and almost finished.
> 
> Thanks,
> Johan

To be fair, we can heap allocate this and just never delete it until ~Compile is called.

-------------

PR: https://git.openjdk.org/jdk/pull/10396


More information about the hotspot-compiler-dev mailing list