RFR: 8294245: Make Compile::print_inlining_stream stack allocated [v2]

Johan Sjölen jsjolen at openjdk.org
Sat Sep 24 10:09:26 UTC 2022


> Hi,
> 
> Could I have  a review for this? It simplifies some auxiliary code in the Compile class related to its usage of stringStream. The only notable disadvantage is that Compile will take up `sizeof(stringStream) - sizeof(stringStream*)` more space on the stack.
> 
> Currently testing tier1-3 for this change, no errors yet and almost finished.
> 
> Thanks,
> Johan

Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:

  Make it heap allocated, but only delete at dtr

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10396/files
  - new: https://git.openjdk.org/jdk/pull/10396/files/137f8689..f02f8845

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10396&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10396&range=00-01

  Stats: 15 lines in 2 files changed: 10 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/10396.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10396/head:pull/10396

PR: https://git.openjdk.org/jdk/pull/10396


More information about the hotspot-compiler-dev mailing list