RFR: 8294245: Make Compile::print_inlining_stream stack allocated [v3]

Johan Sjölen jsjolen at openjdk.org
Sat Sep 24 10:18:11 UTC 2022


> Hi,
> 
> Could I have  a review for this? It simplifies some auxiliary code in the Compile class related to its usage of stringStream. The only notable disadvantage is that Compile will take up `sizeof(stringStream) - sizeof(stringStream*)` more space on the stack.
> 
> Currently testing tier1-3 for this change, no errors yet and almost finished.
> 
> Thanks,
> Johan

Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:

 - No destructor is necessary for ResourceObjs
 - Fix compilation error

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10396/files
  - new: https://git.openjdk.org/jdk/pull/10396/files/f02f8845..c62a8011

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10396&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10396&range=01-02

  Stats: 9 lines in 2 files changed: 0 ins; 8 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/10396.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10396/head:pull/10396

PR: https://git.openjdk.org/jdk/pull/10396


More information about the hotspot-compiler-dev mailing list