RFR: 8294245: Make Compile::print_inlining_stream stack allocated [v3]

Vladimir Kozlov kvn at openjdk.org
Sun Sep 25 00:28:39 UTC 2022


On Sat, 24 Sep 2022 10:18:11 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have  a review for this? It simplifies some auxiliary code in the Compile class related to its usage of stringStream. The only notable disadvantage is that Compile will take up `sizeof(stringStream) - sizeof(stringStream*)` more space on the stack.
>> 
>> Currently testing tier1-3 for this change, no errors yet and almost finished.
>> 
>> Thanks,
>> Johan
>
> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - No destructor is necessary for ResourceObjs
>  - Fix compilation error

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10396


More information about the hotspot-compiler-dev mailing list