RFR: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"

[Christian Hagedorn]

On Fri, 23 Sep 2022 15:48:21 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> PhaseMacroExpand::generate_partial_inlining_block() adds
> LoadVectorMasked nodes to the IR graph and then
> LoadNode::split_through_phi() tries to split one of them through phi
> but because that method ignores the mask input to that LoadNode (it
> only knows about control, memory and address inputs) the resulting
> graph is broken. Fix I propose is to skip
> LoadNode::split_through_phi() for those LoadVector nodes that have
> extra inputs.

That looks reasonable!

src/hotspot/share/opto/memnode.cpp line 1488:

> 1486: //------------------------------split_through_phi------------------------------
> 1487: // Split instance or boxed field load through Phi.
> 1488: Node* LoadNode::split_through_phi(PhaseGVN *phase) {

Suggestion:

Node* LoadNode::split_through_phi(PhaseGVN* phase) {

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10410