RFR: 8292780: misc tests failed "assert(false) failed: graph should be schedulable" [v2]

Tobias Hartmann thartmann at openjdk.org
Mon Sep 26 11:35:21 UTC 2022


On Mon, 26 Sep 2022 11:25:27 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> PhaseMacroExpand::generate_partial_inlining_block() adds
>> LoadVectorMasked nodes to the IR graph and then
>> LoadNode::split_through_phi() tries to split one of them through phi
>> but because that method ignores the mask input to that LoadNode (it
>> only knows about control, memory and address inputs) the resulting
>> graph is broken. Fix I propose is to skip
>> LoadNode::split_through_phi() for those LoadVector nodes that have
>> extra inputs.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/hotspot/share/opto/memnode.cpp
>   
>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>

Thanks, I updated the affected versions. The fix looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10410


More information about the hotspot-compiler-dev mailing list