RFR: 8282365: Optimize divideUnsigned and remainderUnsigned for constants [v3]
Quan Anh Mai
qamai at openjdk.org
Tue Sep 27 19:10:28 UTC 2022
On Tue, 20 Sep 2022 00:11:23 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into unsignedDiv
>> - micro
>> - whitespace
>> - whitespace
>> - large divisor
>> - fix build
>> - fix 32-bit
>> - constant folding, mod idealisation, tests
>> - 32 bit
>> - backend
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/38a81913...3052b4ee
>
> src/hotspot/share/opto/divnode.cpp line 1118:
>
>> 1116: if (in(0) && remove_dead_region(phase, can_reshape)) return this;
>> 1117: // Don't bother trying to transform a dead node
>> 1118: if( in(0) && in(0)->is_top() ) return nullptr;
>
> Please use correct style in new code here and other places (even for one liner):
>
> if (cond) {
> body;
> }
Thanks for your reviews, I have changed the code style in these places.
-------------
PR: https://git.openjdk.org/jdk/pull/9947
More information about the hotspot-compiler-dev
mailing list