RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large [v5]

[Roland Westrelin]

On Fri, 23 Sep 2022 16:33:21 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Thanks for reviewing this.
>> 
>>> Should we move `check_no_dead_use()` call after `final_graph_reshaping()` call because we may have dead uses?
>> 
>> Yes, but we would then hit: https://bugs.openjdk.org/browse/JDK-8211759 
>> That is, there are other transformations in final graph reshape that don't properly collect dead nodes so I think this should be done as a standalone change.
>
>> Thanks for reviewing this.
>> 
>> > Should we move `check_no_dead_use()` call after `final_graph_reshaping()` call because we may have dead uses?
>> 
>> Yes, but we would then hit: https://bugs.openjdk.org/browse/JDK-8211759 That is, there are other transformations in final graph reshape that don't properly collect dead nodes so I think this should be done as a standalone change.
> 
> Okay. I agree on separate changes.

thanks for the review @vnkozlov and testing @TobiHartmann

-------------

PR: https://git.openjdk.org/jdk/pull/10038