RFR: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Sep 29 10:36:26 UTC 2022


On Mon, 26 Sep 2022 17:40:23 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Describe behavior in README.md
>>  - Use whitespaces consistently
>>  - Require C2
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPreconditions.java line 44:
> 
>> 42:     // The IR check should not be applied, since LoopMaxUnroll is set to 8.
>> 43:     @Test
>> 44:     @IR(applyIf = {"LoopMaxUnroll", "= 0"},
> 
> Comment contradict value in condition: `LoopMaxUnroll is set to 8.` vs `"LoopMaxUnroll", "= 0"`

Clarified.

-------------

PR: https://git.openjdk.org/jdk/pull/10402


More information about the hotspot-compiler-dev mailing list