RFR: 8294514: Wrong initialization of nmethod::_consts_offset for native nmethods
Vladimir Kozlov
kvn at openjdk.org
Thu Sep 29 18:07:21 UTC 2022
On Thu, 29 Sep 2022 08:16:27 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
> Hi,
>
> this small fix copies the initialization of `nmethod::_consts_offset` from the nmethod constructor for c1/c2 compiled nmethods to the constructor for native nmethods.
>
> Manual testing:
>
> * I built commit 86097e20df0652c2f0c6865f0ec62e7989db45ca and reproduced the issue on x86_64 as described in the JBS-bug
> * Then I build commit 5ce7741ffd9323909b7424255d696525db3d01d2 and found that I could not reproduce the issue. I also verified that on PPC64 the constants section of the continuation enter intrinsic is printed now (-XX:+PrintAssembly).
>
> The fix passed our CI testing: most JCK and JTREG test, also in Xcomp mode, SPECjvm2008, SPECjbb2015, Renaissance Suite and SAP specific tests with fastdebug and release builds on the standard platforms plus PPC64.
>
> Thanks, Richard.
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10482
More information about the hotspot-compiler-dev
mailing list