RFR: 8291801: IGV: Broken button "Hide graphs which are the same as the previous graph" [v2]

[Koichi Sakata]

On Thu, 29 Sep 2022 09:36:04 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Koichi Sakata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Set value to hideDuplicates field
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8291801
>>  - Remove extra whitespaces
>>  - Improve the test
>>  - Add the test method
>>  - Remove extra code
>>  - Fix the broken button "Hide graphs which are the same as the previous graph" in IGV
>
> I could also reproduce the issue on Windows 10, using JDK 11.0.16.
> 
> I noticed an interesting pattern (on both Linux and Windows): if I iterate a few times the following sequence, the number of hidden graphs grows monotonically (but non-deterministically), and after a few iterations all graphs expected to be hidden are indeed hidden:
> 1. Open `hello.xml`
> 2. Open any graph of the `virtual void java.lang.Object.<init>()` group
> 3. Click on the "Hide graphs which are the same..." button
> 4. Click on "Remove all graphs and groups" button in the Outline window.

@robcasloz I can fully reproduce them on windows! I'll start to fix the behavior. I didn't expect this to depend on the OS. I highly appreciate your support.

@tobiasholenstein Thank you for your advice! I've seen `Difference.java` before writing this patch, too. So I agree with your thought that the function of `Difference` class is too much for this PR. I'll try to fix the `equals` problem in the `isSameContent` method,  change in the timing of determining duplications of graphs.

-------------

PR: https://git.openjdk.org/jdk/pull/10440