RFR: 8294609: C2: Improve inlining of methods with unloaded signature classes [v3]
Dean Long
dlong at openjdk.org
Fri Sep 30 20:11:35 UTC 2022
On Fri, 30 Sep 2022 16:56:36 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> src/hotspot/share/ci/ciMethod.cpp line 1168:
>>
>>> 1166: // it makes signature classes visible through loader constraints.
>>> 1167: // So, encountering an unloaded class signals it is absent both in
>>> 1168: // the callee (local) and caller contexts.
>>
>> Suggestion:
>>
>> // the callee (local) and caller contexts, because linking loads signature classes.
>
> Can you elaborate, please? Neither method resolution nor method selection steps trigger loading of signature classes.
Maybe "loads signature classes" is the wrong choice of words. I mean what SystemDictionary::check_signature_loaders() does. Using the CI interface is guaranteed to go through SystemDictionary::check_signature_loaders(), right?
-------------
PR: https://git.openjdk.org/jdk/pull/10496
More information about the hotspot-compiler-dev
mailing list