RFR: JDK-8305356: Fix ignored bad CompileCommands in tests [v2]
Tobias Holenstein
tholenstein at openjdk.org
Mon Apr 3 12:53:52 UTC 2023
> The following tests have a wrong `CompileCommand` and print an error message in `CompilerOracle::print_parse_error`:
>
> * missing `::*`:
> - `test/hotspot/jtreg/compiler/loopopts/TestPeelingRemoveDominatedTest.java`
>
> * used unsupported quotation marks `""`:
> - `test/hotspot/jtreg/compiler/integerArithmetic/TestNegMultiply.java`
> - `test/hotspot/jtreg/compiler/integerArithmetic/TestNegAnd.java`
>
> * Use of the pattern `CompileCommand=option,Klass::method,type,option,value` but `DisableIntrinsic` has type option type `ccstrlist` and not `ccstr`:
> - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestMulAdd.java`
> - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestMultiplyToLen.java`
> - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestShift.java`
> - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestSquareToLen.java`
Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
copyright year
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13297/files
- new: https://git.openjdk.org/jdk/pull/13297/files/a9943e26..c86155aa
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13297&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13297&range=00-01
Stats: 7 lines in 7 files changed: 2 ins; 0 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/13297.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13297/head:pull/13297
PR: https://git.openjdk.org/jdk/pull/13297
More information about the hotspot-compiler-dev
mailing list