RFR: 8303147: [s390x] fast & slow debug builds are broken [v3]
Amit Kumar
amitkumar at openjdk.org
Tue Apr 4 03:49:07 UTC 2023
On Tue, 4 Apr 2023 03:42:54 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> This PR fixes broken fast debug and slow debug build for s390x-arch. tier1 test are completed and results are not affect after this patch.
>
> Amit Kumar has updated the pull request incrementally with three additional commits since the last revision:
>
> - updates assert condition
> - Revert "build fix for s390x"
>
> This reverts commit bb0ae5d8340b8fd99c4c8d7ab5623739e4d2fa7a.
> - Revert "use constant instead of enum"
>
> This reverts commit 820e288422e86e14323872dbe21550915e28c7e9.
`FrameMap::first_available_sp_in_frame` was non-zero for s390x & PPC, and set to 0 for all other archs. Initially factor was `4` so things were fine but now it changed to `2` which became problematic for us. Now we have modified asserts.
Thanks to @RealLucy for suggestion & help.
@TheRealMDoerr or @reinrich would one of you review this PR as well ?
Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12825#issuecomment-1495304927
More information about the hotspot-compiler-dev
mailing list