RFR: 8305543: Ensure GC barriers for arraycopy on AArch64 use caller saved neon temp registers

Erik Österlund eosterlund at openjdk.org
Wed Apr 5 09:32:20 UTC 2023


On Wed, 5 Apr 2023 08:46:43 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Looks good! We should improve our test coverage in this area.
>
>> Looks good! We should improve our test coverage in this area.
> 
> In debug mode we could (fairly easily?) check for corruption. We could also clobber all of the call-clobbered registers.

Thanks for the reviews @theRealAph  and @robcasloz!

> > Looks good! We should improve our test coverage in this area.
> 
> 
> 
> In debug mode we could (fairly easily?) check for corruption. We could also clobber all of the call-clobbered registers.

Yes @xmas92 had a similar idea to check for clobbering, but I think we should do that for all these stubs in the stub generator, rather than make it an arraycopy thing, IMO.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13325#issuecomment-1497188269
PR Comment: https://git.openjdk.org/jdk/pull/13325#issuecomment-1497190687


More information about the hotspot-compiler-dev mailing list