Integrated: JDK-8305356: Fix ignored bad CompileCommands in tests

Tobias Holenstein tholenstein at openjdk.org
Wed Apr 5 09:39:24 UTC 2023


On Mon, 3 Apr 2023 12:31:41 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> The following tests have a wrong `CompileCommand` and print an error message in `CompilerOracle::print_parse_error`: 
> 
> * missing `::*`:
>    - `test/hotspot/jtreg/compiler/loopopts/TestPeelingRemoveDominatedTest.java` 
> 
> * used unsupported quotation marks `""`:
>    - `test/hotspot/jtreg/compiler/integerArithmetic/TestNegMultiply.java` 
>    - `test/hotspot/jtreg/compiler/integerArithmetic/TestNegAnd.java` 
> 
> * Use of the pattern `CompileCommand=option,Klass::method,type,option,value` but  `DisableIntrinsic`  has type option type `ccstrlist` and not `ccstr`:
>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestMulAdd.java` 
>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestMultiplyToLen.java` 
>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestShift.java` 
>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestSquareToLen.java`

This pull request has now been integrated.

Changeset: 0e0c022b
Author:    Tobias Holenstein <tholenstein at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0e0c022b1f870806963789afdef9298851719498
Stats:     25 lines in 7 files changed: 2 ins; 0 del; 23 mod

8305356: Fix ignored bad CompileCommands in tests

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/13297


More information about the hotspot-compiler-dev mailing list