RFR: JDK-8305644: IGV: Node text not updated when switching from/to CFG view

[Christian Hagedorn]

On Wed, 5 Apr 2023 09:33:21 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> When switching the layouting mode to or from CFG the node text is not updated.
> 
> - Switching to `CFG view` gave the wrong node text: 
> <img width="487" alt="fail_to" src="https://user-images.githubusercontent.com/71546117/230041157-9f6613ef-112c-44d6-8263-63f33c9e56e3.png">
> - with this fix it looks like this
> <img width="514" alt="fix_to" src="https://user-images.githubusercontent.com/71546117/230041139-09f10865-958c-415c-96fe-b036cc2c061a.png">
> 
> - Switching from `CFG view` gave the wrong node text: 
> <img width="682" alt="fail_from" src="https://user-images.githubusercontent.com/71546117/230041151-7c56e33e-7fd2-46cb-b73d-70a7d194f666.png">
> - with this fix it looks like this
> <img width="599" alt="fix-from" src="https://user-images.githubusercontent.com/71546117/230041147-734d1fd0-507b-462e-a4d2-d8b039f333dc.png">

Given that this line was dropped by mistake, the fix to add the line again looks good and trivial. Nevertheless, setting a field in a getter method like that seems wrong/unexpected.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13348#pullrequestreview-1372712215