RFR: 8300829: Make CtwRunner available as an independent tool [v2]
Paul Hohensee
phh at openjdk.org
Thu Apr 6 14:08:15 UTC 2023
On Wed, 5 Apr 2023 16:55:59 GMT, Joshua Cao <duke at openjdk.org> wrote:
>> test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java line 60:
>>
>>> 58: * comma-separated arguments to pass to CTW subprocesses.
>>> 59: */
>>> 60: public static final String CTW_EXTRA_ARGS
>>
>> how about you use getProperty("sun.hotspot.tools.ctwrunner.ctw_extra_args", "").
>> by giving it an empty string as default value, you can take iout if (null != CTW_EXTRA_ARGS) below.
>>
>> btw, you may also need to update the year in the copyrights header.
>
> Yup. Made these changes.
Better to make CTW_EXTRA_ARGS private. If it's needed outside this class, add a public accessor. Don't think it's needed outside though.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13344#discussion_r1159848680
More information about the hotspot-compiler-dev
mailing list