RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v6]

Quan Anh Mai qamai at openjdk.org
Fri Apr 7 18:06:53 UTC 2023


On Fri, 7 Apr 2023 11:51:21 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small cosmetics
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java line 96:
> 
>> 94:         }
>> 95:         Vector<?> shufvec = this.toBitsVector();
>> 96:         VectorMask<?> vecmask = shufvec.compare(VectorOperators.LT, 0);
> 
> This may impact the intrinsification over AVX1 targets for floating point shuffles. Since bits vector is an integral vector and AVX1 does support 32 byte floats but not 32 byte integral vectors.

Yes I think it is a drawback of this approach, however currently we do not support shuffling for 256-bit vectors on AVX1 machines either, and AVX1 seems to be a special case in this regard. This species of float and double may also be less common in the usage of Vector API since it is larger than SPECIES_PREFERRED.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13093#discussion_r1160868954


More information about the hotspot-compiler-dev mailing list