RFR: 8305740: C2: add print statements to assert: Can't determine return type.
Vladimir Kozlov
kvn at openjdk.org
Mon Apr 10 18:48:00 UTC 2023
On Fri, 7 Apr 2023 09:08:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
> I added this assert before the bailout, because it probably hides bugs. Now we have failure reports with [JDK-8305185](https://bugs.openjdk.org/browse/JDK-8305185).
>
> It is difficult to reproduce, so I'd like to add some print statements to get at least a bit of info.
>
> Passed tests up to tier5 and stress testing.
Yes. When you are adding assert always consider what information you will need to debug it.
Marked as reviewed by kvn (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/13385#pullrequestreview-1377958239
PR Review: https://git.openjdk.org/jdk/pull/13385#pullrequestreview-1377958553
More information about the hotspot-compiler-dev
mailing list