RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v7]

Cesar Soares Lucas cslucas at openjdk.org
Tue Apr 11 22:06:42 UTC 2023


On Thu, 6 Apr 2023 04:34:52 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge with Master
>>  - Addressing PR review 2: refactor & reuse MacroExpand::scalar_replacement method.
>>  - Address PR feeedback 1: make ObjectMergeValue subclass of ObjectValue & create new IR class to represent scalarized merges.
>>  - Add support for SR'ing some inputs of merges used for field loads
>>  - Fix some typos and do some small refactorings.
>>  - Merge master
>>  - Add support for rematerializing scalar replaced objects participating in allocation merges
>
> src/hotspot/share/opto/output.cpp line 755:
> 
>> 753:       ciKlass* cik = t->is_oopptr()->exact_klass();
>> 754:       assert(cik->is_instance_klass() ||
>> 755:             cik->is_array_klass(), "Not supported allocation.");
> 
> Why spacing changed?

The identation level was incorrect before.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1163375015


More information about the hotspot-compiler-dev mailing list