RFR: 8305324: C2: Wrong execution of vectorizing Interger.reverseBytes [v4]
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 12 03:54:37 UTC 2023
On Wed, 12 Apr 2023 02:33:57 GMT, Daohan Qu <duke at openjdk.org> wrote:
> BTW, I notice that you added this if condition at about 2012 in `jdk8u`, do you remember why you test `is_shift` in the if condition instead of something like `is_rshift` or so?
At that time we had only 3 shift `Int` vector operations: LShiftI, RShiftI, URShiftI. It did not make sense to have separate function only for right shift. For loads all operations work since we take type from load. For not loads we left with only RShiftI and URShiftI after excluding LShiftI.
Note, I am not against executing this code only for right shifts but it needs to be tested. And as separate changes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13406#discussion_r1163564026
More information about the hotspot-compiler-dev
mailing list