RFR: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API [v14]
Dingli Zhang
dzhang at openjdk.org
Fri Apr 14 06:56:41 UTC 2023
On Tue, 11 Apr 2023 02:49:22 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unneeded combination nodes
>
> src/hotspot/cpu/riscv/riscv_v.ad line 175:
>
>> 173: match(Set dst (VectorMaskCmp (Binary src1 src2) (Binary cond vmask)));
>> 174: effect(TEMP tmp);
>> 175: format %{ "vmaskcmp_rvv_masked $dst, $src1, $src2, $vmask, $tmp, $cond" %}
>
> Suggestion: s/vmaskcmp_rvv_masked/vmaskcmp_masked/
Fixed.
> src/hotspot/cpu/riscv/riscv_v.ad line 2561:
>
>> 2559: %}
>> 2560:
>> 2561: instruct vmaskcast_same_esize_rvv(vRegMask dst_src) %{
>
> Suggestion: s/vmaskcast_same_esize_rvv/vmaskcast_same_esize/
Fixed.
> src/hotspot/cpu/riscv/riscv_v.ad line 2565:
>
>> 2563: match(Set dst_src (VectorMaskCast dst_src));
>> 2564: ins_cost(0);
>> 2565: format %{ "vmaskcast_same_esize_rvv $dst_src\t# do nothing" %}
>
> Suggestion: s/vmaskcast_same_esize_rvv/vmaskcast_same_esize/
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1166363159
PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1166363198
PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1166363302
More information about the hotspot-compiler-dev
mailing list