RFR: 8305080: Remove the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests [v2]
Doug Simon
dnsimon at openjdk.org
Mon Apr 17 09:07:01 UTC 2023
On Mon, 17 Apr 2023 08:56:42 GMT, Afshin Zafari <duke at openjdk.org> wrote:
>> The finalize() methods are removed and replaced by Cleaner callbacks.
>>
>> Note:
>> `test/hotspot/jtreg/compiler/jvmci/compilerToVM/HasFinalizableSubclassTest.java` may be removed since there is no need to test if finalize() exists in the subclasses or not..
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
Marked as reviewed by dnsimon (Committer).
Looks good. Only final comment is that I would change the title of this issue from "Remove the..." to "Suppress the...".
-------------
PR Review: https://git.openjdk.org/jdk/pull/13419#pullrequestreview-1387596214
PR Comment: https://git.openjdk.org/jdk/pull/13419#issuecomment-1510971144
More information about the hotspot-compiler-dev
mailing list