RFR: 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 [v4]

Richard Reingruber rrich at openjdk.org
Mon Apr 17 10:36:38 UTC 2023


On Mon, 17 Apr 2023 07:25:36 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> This PR makes parent interpreted Java frames independent of `ABI_ELFv2`.
>> With the changes `test/jdk/jdk/internal/vm/Continuation/BasicExt.java#COMP_ALL` succeeds on PPC64 Big Endian Linux.
>> 
>> Before:
>> 
>> * `parent_ijava_frame_abi` was derived from `abi_minframe` which depends on `ABI_ELFv2`
>> * jit_abi is independent of `abi_minframe`
>> * `frame::metadata_words` is wrong for `parent_ijava_frame_abi` if `ABI_ELFv2` is not defined (big endian)
>> 
>> After changes:
>> 
>> * prefixed structs that depend on `ABI_ELFv2` with `native_`
>> * introduced `java_abi` which is independent of `ABI_ELFv2`
>> * `frame::metadata_words` is the size in words of `java_abi`
>> 
>> This is still a little imprecise since `top_ijava_frame_abi` is larger than `java_abi` but the top frame is never frozen as it is always `vmIntrinsics::_Continuation_doYield`
>> 
>> Testing:
>> 
>> PPC64le: most JCK and JTREG tiers 1-4, also in Xcomp mode.
>> PPC64be Linux: hotspot tier1 tests
>
> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Copyright years

Another round of testing succeeded (tier 1 - 4).
On AIX `serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java` fails because the PollsetPoller is not fully implemented there. @backwaterred is working on it.
Thanks for the reviews. I'm planning to integrate the pr tomorrow.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13372#issuecomment-1511098385


More information about the hotspot-compiler-dev mailing list