Integrated: 8305543: Ensure GC barriers for arraycopy on AArch64 use caller saved neon temp registers
Erik Österlund
eosterlund at openjdk.org
Mon Apr 17 12:16:43 UTC 2023
On Tue, 4 Apr 2023 13:02:05 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
> The arraycopy stubs on AArch64 now allows the GC to vectorize arraycopy barriers. That's great! But the gct3 registers we hand to the GC is v8 today, which is callee saved (well at least the lower 64 bits). Therefore, if the GC clobbers this temp registers, it can have unexpected side effects on the caller float/double registers. We should use a caller saved register instead.
> This is only used by generational ZGC, so isn't a mainline bug yet. We should fix it before it becomes one.
This pull request has now been integrated.
Changeset: 2240c7ec
Author: Erik Österlund <eosterlund at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2240c7ec2fd87a4fd5670f88b9e7dcb3758294c6
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
8305543: Ensure GC barriers for arraycopy on AArch64 use caller saved neon temp registers
Reviewed-by: rcastanedalo, aph
-------------
PR: https://git.openjdk.org/jdk/pull/13325
More information about the hotspot-compiler-dev
mailing list