Integrated: 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2
Richard Reingruber
rrich at openjdk.org
Tue Apr 18 07:03:00 UTC 2023
On Thu, 6 Apr 2023 13:22:49 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
> This PR makes parent interpreted Java frames independent of `ABI_ELFv2`.
> With the changes `test/jdk/jdk/internal/vm/Continuation/BasicExt.java#COMP_ALL` succeeds on PPC64 Big Endian Linux.
>
> Before:
>
> * `parent_ijava_frame_abi` was derived from `abi_minframe` which depends on `ABI_ELFv2`
> * jit_abi is independent of `abi_minframe`
> * `frame::metadata_words` is wrong for `parent_ijava_frame_abi` if `ABI_ELFv2` is not defined (big endian)
>
> After changes:
>
> * prefixed structs that depend on `ABI_ELFv2` with `native_`
> * introduced `java_abi` which is independent of `ABI_ELFv2`
> * `frame::metadata_words` is the size in words of `java_abi`
>
> This is still a little imprecise since `top_ijava_frame_abi` is larger than `java_abi` but the top frame is never frozen as it is always `vmIntrinsics::_Continuation_doYield`
>
> Testing:
>
> PPC64le: most JCK and JTREG tiers 1-4, also in Xcomp mode.
> PPC64be Linux: hotspot tier1 tests
This pull request has now been integrated.
Changeset: 445ebef4
Author: Richard Reingruber <rrich at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/445ebef4371569b574af698138dccb159ce95602
Stats: 161 lines in 21 files changed: 13 ins; 13 del; 135 mod
8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2
Reviewed-by: mdoerr
-------------
PR: https://git.openjdk.org/jdk/pull/13372
More information about the hotspot-compiler-dev
mailing list