RFR: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API [v22]
Dingli Zhang
dzhang at openjdk.org
Wed Apr 19 02:51:04 UTC 2023
On Wed, 19 Apr 2023 02:37:35 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:
>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix build fail after JDK-8305008
>
> src/hotspot/cpu/riscv/riscv_v.ad line 199:
>
>> 197: // vector mask float compare
>> 198:
>> 199: instruct vmaskcmp_DF(vRegMask dst, vReg src1, vReg src2, immI cond, vReg tmp1, vReg tmp2) %{
>
> Would you please rename `vmaskcmp_DF` to `vmaskcmp_FD`? We got `minmax_FD_v` already.
Thanks! Fixed.
> src/hotspot/cpu/riscv/riscv_v.ad line 216:
>
>> 214: %}
>> 215:
>> 216: instruct vmaskcmp_DF_masked(vRegMask dst, vReg src1, vReg src2, immI cond, vRegMask_V0 vmask, vReg tmp1, vReg tmp2, vReg tmp3) %{
>
> ditto
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1170752063
PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1170752084
More information about the hotspot-compiler-dev
mailing list