RFR: 8306456: Don't leak _worklist's memory in PhaseLive::compute
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 19 17:56:43 UTC 2023
On Wed, 19 Apr 2023 14:21:13 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> `PhaseLive::compute` used to do this: `_worklist = new (_arena) Block_List();`. This allocates the `Block_List` to the `_arena`, but the backing array is allocated on the resource area: `Block_List() : Block_Array(Thread::current()->resource_area()), _cnt(0) {}`. This causes at most 5 worklists and at least 4 worklists to be created and not freed until the compilation is finished. This patch allocates the worklist within `PhaseLive::compute`:s local resource mark.
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13535#pullrequestreview-1392607956
More information about the hotspot-compiler-dev
mailing list