RFR: 8301739: AArch64: Add optimized rules for vector compare with immediate for SVE [v3]

[Andrew Haley]

On Thu, 20 Apr 2023 02:25:45 GMT, Chang Peng <duke at openjdk.org> wrote:

>> We can use SVE compare-with-integer-immediate instructions like cmpgt(immediate)[1] to avoid the extra scalar2vector operations.
>> 
>> The following instruction sequence
>> 
>> 
>> movi    v17.16b, #12
>> cmpgt   p0.b, p7/z, z16.b, z17.b
>> 
>> 
>> can be optimized to:
>> 
>> 
>> cmpgt   p0.b, p7/z, z16.b, #12
>> 
>> 
>> This patch does the following:
>> 1. Add SVE compare-with-7bit-unsigned-immediate instructions to C2's backend.
>> SVE cmp<cc>(immediate) instructions can support vector comparing with 7bit unsigned integer immediate (range from 0 to 
>> 127)or 5bit signed integer immediate (range from -16 to 15).
>> 
>> 2. Add optimized match rules to generate the compare-with-immediate instructions.
>> 
>> [1]: https://developer.arm.com/documentation/ddi0596/2021-12/SVE-Instructions/CMP-cc---immediate---Compare-vector-to-immediate-
>
> Chang Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor some code

src/hotspot/cpu/aarch64/aarch64_vector_ad.m4 line 3656:

> 3654:   ins_pipe(pipe_slow);
> 3655: %}')dnl
> 3656: VMASKCMP_SVE_IMM_I(immI5, cmp)

This is tricky to review because the two macros here seems to be almost, but not exactly, the same. Why is that?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13200#discussion_r1172239949