RFR: 8301739: AArch64: Add optimized rules for vector compare with immediate for SVE [v3]
Andrew Haley
aph at openjdk.org
Thu Apr 20 14:54:46 UTC 2023
On Thu, 20 Apr 2023 09:08:28 GMT, Chang Peng <duke at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/aarch64_vector_ad.m4 line 3656:
>>
>>> 3654: ins_pipe(pipe_slow);
>>> 3655: %}')dnl
>>> 3656: VMASKCMP_SVE_IMM_I(immI5, cmp)
>>
>> This is tricky to review because the two macros here seems to be almost, but not exactly, the same. Why is that?
>
> This patch adds rules for vector comparing with immediate. These immediate may have different types and his manifests as different ConNodes in middle-end (ConI and ConL). ConI and ConL have different methods to get the value, i.e., get_int() for ConI and get_long() for ConL. We should use this value in predicate, so I set two macros, one for integer (byte, short and int) and another one for long.
Please show me where these differences appear. I can't see them.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13200#discussion_r1172714471
More information about the hotspot-compiler-dev
mailing list