RFR: 8304676: [vectorapi] x86_32: Crash in Assembler::kmovql(Address, KRegister)

Aleksey Shipilev shade at openjdk.org
Mon Apr 24 08:46:44 UTC 2023


On Sun, 23 Apr 2023 19:51:58 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> Can I have reviews for this patch which fixes crashes during PrintOptoAssembly of KRegister spilling code. The reason is that we miss the check for nullptr cbuf.
> 
> Thanks a lot.

This looks fine, and it matches what the surrounding code does when `cbuf` is `nullptr`.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13603#pullrequestreview-1397469708


More information about the hotspot-compiler-dev mailing list