RFR: 8301739: AArch64: Add optimized rules for vector compare with immediate for SVE [v3]
Andrew Haley
aph at openjdk.org
Mon Apr 24 10:13:44 UTC 2023
On Sun, 23 Apr 2023 04:21:14 GMT, Chang Peng <duke at openjdk.org> wrote:
> @theRealAph The ReplicateXNodes used in match rules are also different in these two marcos. I think we needn't to merge these two marcos since this will introduce some if-else statements which will reduce the readability.
It won't introduce if-else, surely. Not if you make the parts that are different into parameters. Then a reviewer cand immediately see which parts of the macros are actually different, rather than needing to do a deep study.;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13200#discussion_r1175073413
More information about the hotspot-compiler-dev
mailing list