RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

[Jatin Bhateja]

On Tue, 25 Apr 2023 11:57:21 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   style
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 1914:
> 
>> 1912:   if (vector_klass->const_oop() == NULL || elem_klass->const_oop() == NULL ||
>> 1913:       !vlen->is_con() || !origin_type->is_con()) {
>> 1914:     if (C->print_intrinsics()) {
> 
> Hi @merykitty , your inline expander is not handling non-constant origin case, this will introduce performance regressions w.r.t to existing implementation.

You can extend expander to generate IR corresponding to fallback implementation to handle non-constant origin case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12909#discussion_r1176410139