RFR: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API [v32]

[Dingli Zhang]

On Tue, 25 Apr 2023 07:29:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove useless BasicType bt
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1755:
> 
>> 1753:   // exception on both signaling and quiet NaN inputs, so we should
>> 1754:   // mask the signaling compares when either input is NaN
>> 1755:   // to implement floating-point quiet compares.
> 
> I think we can check the vector elements for NaNs here with the Vector Floating-Point Classify Instruction? That would avoid raising invalid operation exception as a side effect with the current solution.

Fixed.

> src/hotspot/cpu/riscv/riscv_v.ad line 1528:
> 
>> 1526:   match(Set dst_src (RShiftVB (Binary dst_src shift) v0));
>> 1527:   ins_cost(VEC_COST);
>> 1528:   effect(TEMP_DEF dst_src, USE v0, TEMP tmp);
> 
> No need to add 'USE v0' in effect for this instruct and several other ones.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1176459908
PR Review Comment: https://git.openjdk.org/jdk/pull/12682#discussion_r1176460417