RFR: 8051725: Improve expansion of Conv2B nodes in the middle-end [v6]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Tue Apr 25 14:43:23 UTC 2023
> Hi, I've created optimizations for the expansion of `Conv2B` nodes, especially when followed immediately by an xor of 1. This pattern is fairly common, and can arise from both [cmov idealization](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/movenode.cpp#L241) and [diamond-phi optimization](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/cfgnode.cpp#L1571). This change replaces `Conv2B` nodes in the middle-end during post loop opts IGVN with conditional moves on supported platforms (x86_64, aarch64, arm32), allowing the bit flip with `xor` to be subsumed with an inversion of the comparison instead. This change also reduces the overhead of the matcher in the backends, as fewer rules need to be traversed in order to match an ideal node. Performance results from my (Zen 2) machine:
>
>
> Baseline Patch Improvement
> Benchmark Mode Cnt Score Error Units Score Error Units
> Conv2BRules.testEquals0 avgt 10 47.566 ± 0.346 ns/op / 34.130 ± 0.177 ns/op + 28.2%
> Conv2BRules.testNotEquals0 avgt 10 37.167 ± 0.211 ns/op / 34.185 ± 0.258 ns/op + 8.0%
> Conv2BRules.testEquals1 avgt 10 35.059 ± 0.280 ns/op / 34.847 ± 0.160 ns/op (unchanged)
> Conv2BRules.testEqualsNull avgt 10 56.768 ± 2.600 ns/op / 34.330 ± 0.625 ns/op + 39.5%
> Conv2BRules.testNotEqualsNull avgt 10 47.447 ± 1.193 ns/op / 34.142 ± 0.303 ns/op + 28.0%
>
> Reviews would be greatly appreciated!
>
> Testing: tier1-2 on linux x64, GHA
Jasmine Karthikeyan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
- Merge branch 'master' into conv2b-x86-lowering
- Whitespace tweak
- Make transform conditional
- Remove Conv2B from backend as it's macro expanded now
- Re-work transform to happen in macro expansion
- Fix whitespace and add bug tag to IR test
- Merge branch 'master' into conv2b-x86-lowering
- Merge branch 'master' into conv2b-x86-lowering
- Merge branch 'master' into conv2b-x86-lowering
- Merge branch 'master' into conv2b-x86-lowering
- ... and 1 more: https://git.openjdk.org/jdk/compare/bad6aa68...295b9a67
-------------
Changes: https://git.openjdk.org/jdk/pull/13345/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13345&range=05
Stats: 358 lines in 14 files changed: 241 ins; 114 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/13345.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13345/head:pull/13345
PR: https://git.openjdk.org/jdk/pull/13345
More information about the hotspot-compiler-dev
mailing list