RFR: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if [v2]

Dean Long dlong at openjdk.org
Tue Apr 25 17:26:08 UTC 2023


On Mon, 24 Apr 2023 18:10:44 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This change removes undefined behavior caused by signed overflow, which triggered an assert with Xcode14.3+1.0-beta1 on macos aarch64.
>
> Dean Long has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update src/hotspot/share/opto/parse2.cpp
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>  - Update src/hotspot/share/opto/parse2.cpp
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>

I think I'll just leave the names as-is.  The comments in the code seem to use "count" and "counter" interchangeably.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13551#issuecomment-1522153183


More information about the hotspot-compiler-dev mailing list