RFR: 8306966: RISC-V: Support vector cast node for Vector API [v3]

Gui Cao gcao at openjdk.org
Fri Apr 28 12:21:28 UTC 2023


On Fri, 28 Apr 2023 02:31:15 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   During the conversion, specify the number of vectors
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1797:
> 
>> 1795:   assert_different_registers(dst, src);
>> 1796: 
>> 1797:   rvv_vsetvli(dst_bt, length_in_bytes);
> 
> I think we should use the actual AVL instread of 'length_in_bytes' for rvv_vsetvli ?

No problem here, https://github.com/openjdk/jdk/blob/3554e7a3ffb879c7e5ef7547eb053e484d09d12b/src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp#L1830 There was a problem here and it has been fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13684#discussion_r1180328798


More information about the hotspot-compiler-dev mailing list