RFR: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers [v2]

[Aleksey Shipilev]

On Wed, 2 Aug 2023 07:47:09 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8313248-shenandoah-nullcheck
>>  - Proper fix
>>  - Trying to pin more
>>  - Reverts
>>  - Debugging
>
> src/hotspot/share/opto/library_call.cpp line 3591:
> 
>> 3589: const Type* LibraryCallKit::scopedValueCache_type() {
>> 3590:   ciKlass *objects_klass = ciObjArrayKlass::make(env()->Object_klass());
>> 3591:   const TypeOopPtr *etype = TypeOopPtr::make_from_klass(env()->Object_klass());
> 
> Suggestion:
> 
>   ciKlass* objects_klass = ciObjArrayKlass::make(env()->Object_klass());
>   const TypeOopPtr* etype = TypeOopPtr::make_from_klass(env()->Object_klass());

Done so, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15105#discussion_r1281534065