RFR: JDK-8313632: ciEnv::dump_replay_data use fclose
Tobias Hartmann
thartmann at openjdk.org
Thu Aug 3 09:15:31 UTC 2023
On Thu, 3 Aug 2023 08:43:03 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> Seems we miss to call fclose at the end of ciEnv::dump_replay_data .
> This should better be done like it is documented here in the fdopen example :
> https://www.ibm.com/docs/en/i/7.3?topic=functions-fdopen-associates-stream-file-descriptor
>
> I also added close calls in case fdopen fails, should we use them too?
Looks good to me.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15135#pullrequestreview-1560605517
More information about the hotspot-compiler-dev
mailing list