RFR: 8312213: Remove unnecessary TEST instructions on x86 when flags reg will already be set [v4]

[Jorn Vernee]

On Mon, 7 Aug 2023 11:39:10 GMT, Tobias Hotz <duke at openjdk.org> wrote:

>> src/hotspot/share/adlc/output_c.cpp line 4019:
>> 
>>> 4017:   if (inst->_flag != nullptr) {
>>> 4018:     Flag* node = inst->_flag;
>>> 4019:     const char* prefix = "Node::";
>> 
>> You could potentially make the prefix here `Node::PD::`, then the extra `PD::` could be removed from the .ad file (I don't think it really adds much?).
>
> Well I thought that it could also be used to add some non-arch specific flags in the future, and with this the keyword would be more generic and allow for this as well.

Ok, that sounds good. Keep it then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14172#discussion_r1285838828